Implement .as_weak() and .upgrade() for global component instances #9436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennysj
force-pushed
the
global_comp_improvments
branch
4 times, most recently
from
ab2a50a to
595f2e2
Compare
dfaure-kdab
reviewed
Sep 25, 2025
internal/core/api.rs
Outdated
| pub use weak_handle::*; | ||
|
|
||
| /// This trait provides the necessary functionality for allowing creating strongly-referenced | ||
| /// clones and conversion into/ a weak pointer for a Global slint component. |
There was a problem hiding this comment.
into/ ?
Did you mean into/from maybe, or is the / a typo?
internal/core/api.rs
Outdated
| } | ||
|
|
||
| /// Returns a new GlobalStrong struct, where it's possible to get the global component | ||
| /// struct interface. Ff some other instance still |
internal/core/api.rs
Outdated
| if std::thread::current().id() != self.thread { | ||
| return None; | ||
| } | ||
| let coso = T::upgrade_from_weak_inner(&self.inner)?; |
| /// // now forward the data to the main thread using upgrade_in_event_loop | ||
| /// my_app_data_weak.upgrade_in_event_loop(move |my_app_data| my_app_data.set_foo(foo)); | ||
| /// }); | ||
| /// # thread.join().unwrap(); return; // don't run the event loop in examples |
There was a problem hiding this comment.
I'm confused. This is docu, not actual example, why the commented-out code?
There was a problem hiding this comment.
It's a lot of copy / paste from the same function for Weak - at line 930
bennysj
force-pushed
the
global_comp_improvments
branch
3 times, most recently
from
d2882a0 to
91264dc
Compare
The idea to make it easier and more convenient to pass a reference to a Slint global instance into a Rust closure / lambda. Fixes slint-ui#9389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea to make it easier and more convenient to pass a reference to a Slint global instance into a Rust closure / lambda.
The current implementation works the following way:
Fixes #9389